Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1812889) sd-journal: close journal files that were deleted by journald before we've setup inotify watch #99

Merged

Conversation

msekletar
Copy link
Member

No description provided.

…we've setup inotify watch

(cherry-picked from commit 28ca867)

Fixes #14695

Related: #1812889
journal_file_fstat() returns an error if we call it on already unlinked
journal file and hence we never reach remove_file_real() which is the
entire point.

I must have made some mistake while testing the fix that got me thinking
the issue is gone while opposite was true.

Fixes #14695

(cherry-picked from commit 8581b9f)

Resolves: #1812889
@systemd-rhel-bot systemd-rhel-bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Apr 1, 2020
@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-ci Formerly needs-ci label Apr 1, 2020
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Apr 2, 2020
@systemd-rhel-bot systemd-rhel-bot merged commit 7fe6194 into redhat-plumbers:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants