Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1748258) buildsys: don't garbage collect sections while linking #17

Merged
merged 1 commit into from Oct 21, 2019
Merged

(#1748258) buildsys: don't garbage collect sections while linking #17

merged 1 commit into from Oct 21, 2019

Conversation

msekletar
Copy link
Member

gc-sections is actually very aggressive and garbage collects ELF
sections used by annobin gcc plugin and annocheck then reports gaps in
coverage. Let's drop that linker flag.

RHEL-only

Resolves: #1748258

gc-sections is actually very aggressive and garbage collects ELF
sections used by annobin gcc plugin and annocheck then reports gaps in
coverage. Let's drop that linker flag.

RHEL-only

Resolves: #1748258
@msekletar msekletar changed the title buildsys: don't garbage collect sections while linking (#1748258) buildsys: don't garbage collect sections while linking Sep 3, 2019
@systemd-rhel-bot systemd-rhel-bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review tracker/unapproved Formerly needs-acks and removed pr/needs-ci Formerly needs-ci labels Sep 3, 2019
Copy link
Contributor

@jsynacek jsynacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 100kB increase in size is negligible.

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Sep 4, 2019
@systemd-rhel-bot systemd-rhel-bot removed the tracker/unapproved Formerly needs-acks label Oct 21, 2019
@systemd-rhel-bot systemd-rhel-bot merged commit 9f259b4 into redhat-plumbers:master Oct 21, 2019
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/needs-ci Formerly needs-ci released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants