(#1776408) rework how we log about LUKS activation failures #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug() This makes sure that errors reported by libcryptsetup are shown to the user instead of getting swallowed up by log_debug(). (cherry picked from commit aa2cc00) Resolves: #1776408
(cherry picked from commit b7a0fea) Related: #1776408
(cherry picked from commit 44ce425) Related: #1776408
First of all let's always log where the errors happen, and not in an upper stackframe, in all cases. Previously we'd do this somethis one way and sometimes another, which resulted in sometimes duplicate logging and sometimes none. When we cannot activate something due to bad password the kernel gives us EPERM. Let's uniformly return this EAGAIN, so tha the next password is tried. (previously this was done in most cases but not in all) When we get EPERM let's also explicitly indicate that this probably means the password is simply wrong. Fixes: #11498 (cherry picked from commit 6f177c7) Related: #1776408
systemd-rhel-bot
added
pr/needs-ci
systemd-rhel-bot
changed the title
systemd-rhel-bot
added
tracker/unapproved
|
Thanks @dtardon |
systemd-rhel-bot
added
needs-itr
and removed
pr/needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.