Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#1836979) Backport necessary test suite patches for TEST-24-UNIT-TESTS #95

Merged
merged 15 commits into from May 18, 2020
Merged

(#1836979) Backport necessary test suite patches for TEST-24-UNIT-TESTS #95

merged 15 commits into from May 18, 2020

Conversation

mrc0mmand
Copy link
Member

Resolves: #1836979

See: #85

yuwata and others added 14 commits May 18, 2020 17:28
@yuwata @mrc0mmand
test: do not use global variable to pass error
b895bcd 
(cherry picked from commit 0013fac)
(cherry picked from commit a521c49)

Resolves: #1836979
@yuwata @mrc0mmand
test: install libraries required by tests
ce49bb6 
(cherry picked from commit e3d3dad)
(cherry picked from commit 813d60b)

Resolves: #1836979
@yuwata @mrc0mmand
test: introduce install_zoneinfo()
3fb7a4d 
But it is not called by default.

(cherry picked from commit 7d10ec1)
(cherry picked from commit a66d62e)

Resolves: #1836979
@yuwata @mrc0mmand
test: replace duplicated Makefile by symbolic link
15d1111 
(cherry picked from commit dd75c13)
(cherry picked from commit e02d918)

Resolves: #1836979
@yuwata @mrc0mmand
test: add paths of keymaps in install_keymaps()
31c6fe8 
It seems that the paths of directories storing keymaps are changed.

(cherry picked from commit 83a7051)
(cherry picked from commit 808bf3d)

Resolves: #1836979
@yuwata @mrc0mmand
test: make install_keymaps() optionally install more keymaps
6ea53a8 
(cherry picked from commit ad931fe)
(cherry picked from commit bc06966)

Resolves: #1836979
@yuwata @mrc0mmand
test-fs-util: skip some tests when running in unprivileged container
bd3fdb7 
(cherry picked from commit 9590065)
(cherry picked from commit bf2234c)

Resolves: #1836979
@yuwata @mrc0mmand
test-process-util: skip several verifications when running in unprivi…
12c9635 
…leged container

(cherry picked from commit 767eab4)
(cherry picked from commit 2bc26a0)

Resolves: #1836979
@yuwata @mrc0mmand
test-execute: also check python3 is installed or not
3e73047 
(cherry picked from commit 738c74d)
(cherry picked from commit 6750925)

Resolves: #1836979
@yuwata @mrc0mmand
test-execute: skip several tests when running in container
ffb7f84 
(cherry picked from commit 642d1a6)
(cherry picked from commit 3a8ebd8)

Resolves: #1836979
@yuwata @mrc0mmand
test: introduce test_is_running_from_builddir()
66f605c 
(cherry picked from commit 8cb10a4)
(cherry picked from commit 4fa54d7)

Resolves: #1836979
@yuwata @mrc0mmand
test: make test-catalog relocatable
377aad7 
Fixes #10045.

(cherry picked from commit d9b6baa)
(cherry picked from commit 444ad72)

Resolves: #1836979
@mrc0mmand
test: parallelize tasks in TEST-24-UNIT-TESTS
1f3eb37 
(cherry picked from commit 2f2a045)
(cherry picked from commit c06e3ad)

Resolves: #1836979
@mrc0mmand
test: try to determine QEMU_SMP dynamically
4c0bc5d 
If the QEMU_SMP value has not been explicitly set, try to determine it
from the number of online CPUs using the nproc utility. If this approach
fails, fall back to the default value QEMU_SMP=1.

This change should significantly help when running integration tests
under QEMU on multicore systems.

(cherry picked from commit 5bfb2a9)
(cherry picked from commit dd166ab)

Resolves: #1836979
@systemd-rhel-bot systemd-rhel-bot added rhel-8.2.0 pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels May 18, 2020
@systemd-rhel-bot systemd-rhel-bot changed the title Backport necessary test suite patches for TEST-24-UNIT-TESTS (#1836979) Backport necessary test suite patches for TEST-24-UNIT-TESTS May 18, 2020
@mrc0mmand
test: store coredumps in journal
0d5ef1e 
To make debugging much easier, especially for crashes in tests under
QEMU, let's store the entire coredump bundle in the systemd journal,
which is usually kept around by various CIs. Right now, we usually end
up with a journal, but without the coredump itself, which is pretty
useless.

(cherry picked from commit 215bffe)
(cherry picked from commit cac1e15)

Resolves: #1836979
@mrc0mmand mrc0mmand force-pushed the testsuite-backports-8.2.0.z branch from 2a9080f to 0d5ef1e Compare May 18, 2020 15:36
jsynacek
jsynacek approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@jsynacek jsynacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label May 18, 2020
@systemd-rhel-bot systemd-rhel-bot merged commit c8e3d9e into redhat-plumbers:rhel-8.2.0 May 18, 2020
@mrc0mmand mrc0mmand deleted the testsuite-backports-8.2.0.z branch May 19, 2020 12:54
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsynacek jsynacek jsynacek approved these changes

Assignees
No one assigned
Labels
pr/needs-ci Formerly needs-ci released rhel-8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrc0mmand @jsynacek @jamacku @systemd-rhel-bot @yuwata