Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot is sometimes enabled on forks #21343

Closed
evverx opened this issue Nov 13, 2021 · 5 comments
Closed

Dependabot is sometimes enabled on forks #21343

evverx opened this issue Nov 13, 2021 · 5 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@evverx
Copy link
Member

evverx commented Nov 13, 2021

According to https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/enabling-and-disabling-dependabot-version-updates#enabling-version-updates-on-forks

Version updates are not automatically enabled on forks when a dependabot.yml configuration file is present. This ensures that fork owners don't unintentionally enable version updates when they pull changes including a dependabot.yml configuration file from the original repository

but according to dependabot/dependabot-core#2804 (comment)

Dependabot version updates (setup from config file) isn't enabled by default on new forks but will be if security updates has ever been turned on and since disabled.

which means that apparently in some cases forks will receive PRs from Dependabot and the only workaround is

The workaround for now is to delete the fork and re-create it without enabling Dependabot security updates

I don't think it affects a lot of forks but to be sure it would be great if all issues related to PRs from Dependabot could be discussed here.

To somewhat mitigate the issue the number of PRs Dependabot can create will be limited: #21342

@evverx evverx added the dependencies Pull requests that update a dependency file label Nov 13, 2021
@mrc0mmand
Copy link
Member

@eworm-de
Copy link
Contributor

eworm-de commented Dec 6, 2021

This one is really annoying... As the upstream issues are open for a long time already I guess this will not be fixed any time soon. 😒
So time to delete and recreate my fork?

@evverx
Copy link
Member Author

evverx commented Dec 6, 2021

So time to delete and recreate my fork?

Unfortunately, it seems to be the only way to get rid of those PRs

I'm not sure why it opened eworm-de#4 and eworm-de#5 though. Both those updates were blocked in #21505 and #21574.

@evverx
Copy link
Member Author

evverx commented Dec 6, 2021

I'm not sure if it helps but all those PRs are also auto-closed once forks get updated so in principle if PRs like eworm-de#4 were blocked explicitly by using something like https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#ignore in the systemd repository most forks updated at least once a week would never get Dependabot PRs.

@evverx
Copy link
Member Author

evverx commented Nov 20, 2022

Judging by https://github.blog/changelog/2022-11-07-dependabot-pull-requests-off-by-default-for-forks/ it was fixed

@evverx evverx closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

No branches or pull requests

3 participants