systemd-executor should not call log_set_always_reopen_console(true) when running tests

[DaanDeMeyer]

systemd version the issue has been seen with

main

Used distribution

No response

Linux kernel version used

No response

CPU architectures issue was seen on

None

Component

No response

Expected behaviour you didn't see

No response

Unexpected behaviour you saw

log_set_always_reopen_console(true) means we will never log to stderr, which means that either we get the systemd-executor logs on /dev/console, or we got no logs at all during tests such as test-execute when running it from a terminal.

Steps to reproduce the problem

No response

Additional program output to the terminal or log subsystem illustrating the issue

No response

[bluca]

there were some early boot/late shutdown shenanigans there, that I cannot quite remember the details of

[DaanDeMeyer]

I'm not saying we should drop it unconditionally, but when running unit tests it does not make sense to enable it.

[bluca]

Yeah that makes sense, also dropping it if it doesn't cause any issues or there are other workarounds would be fine