CPUQuota= values > 100% are invalid since v231 #3851

Closed
djgera opened this Issue Aug 1, 2016 · 4 comments

Projects

None yet

6 participants

@djgera
djgera commented Aug 1, 2016

Submission type

  • [X ] Bug report
  • Request for enhancement (RFE)

NOTE: Do not submit anything other than bug reports or RFEs via the issue tracker!

systemd version the issue has been seen with

v231

NOTE: Do not submit bug reports about anything but the two most recently released systemd versions upstream!

Used distribution

Arch Linux (x86_64)

In case of bug report: Expected behaviour you didn't see

$ sudo systemctl --runtime set-property ghb@:1.service CPUQuota=200%
$

In case of bug report: Unexpected behaviour you saw

$ sudo systemctl --runtime set-property ghb@:1.service CPUQuota=200%
CPU quota '200%' invalid.

In case of bug report: Steps to reproduce the problem

$ sudo systemctl --runtime set-property ghb@:1.service CPUQuota=200%

@poettering poettering added this to the v232 milestone Aug 2, 2016
@philips
Member
philips commented Aug 3, 2016

@vcaputo could you take a look at this? Related to coreos/coreos-overlay#2106

@ajeddeloh
Contributor

Looks like it was introduced in 9184ca4 since parse_percent checks the value is in the range [0,100]. Looking through the man pages, it appears the CPUQuota is the only place where values >100% are used. Not sure if a "parse_percent_unbounded" should be introduced or just revert the change in that one spot.

@dm0-
Contributor
dm0- commented Aug 4, 2016

I've tested using a parse_percent_unbounded function, which seems to work for me. The PR is #3886.

@vcaputo
Contributor
vcaputo commented Aug 4, 2016

Huh, I only get notified on my personal email for this project, didn't see my mention til now. I believe dm0 is working on this.

@poettering poettering closed this in #3886 Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment