fails to build on x32

[mbiebl]

Submission type

• Bug report
• Request for enhancement (RFE)

systemd version the issue has been seen with

v233

Used distribution

Debian sid

As can be seen at https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=x32&ver=233-2&stamp=1488543082&raw=0 the build fails on x32:

In file included from ../src/basic/alloc-util.h:27:0,
                 from ../src/journal/journald-console.c:24:
../src/journal/journald-console.c: In function 'server_forward_console':
../src/journal/journald-console.c:75:32: error: format '%ld' expects argument of type 'long int', but argument 5 has type '__syscall_slong_t {aka long long int}' [-Werror=format=]
                 xsprintf(tbuf, "[%5"PRI_TIME".%06ld] ",
                                ^
../src/basic/macro.h:45:44: note: in definition of macro '_unlikely_'
 #define _unlikely_(x) (__builtin_expect(!!(x),0))
                                            ^
../src/basic/stdio-util.h:30:9: note: in expansion of macro 'assert_message_se'
         assert_message_se((size_t) snprintf(buf, ELEMENTSOF(buf), fmt, __VA_ARGS__) < ELEMENTSOF(buf), "xsprintf: " #buf "[] must be big enough")
         ^~~~~~~~~~~~~~~~~
../src/journal/journald-console.c:75:17: note: in expansion of macro 'xsprintf'
                 xsprintf(tbuf, "[%5"PRI_TIME".%06ld] ",
                 ^~~~~~~~
cc1: some warnings being treated as errors

[keszybz]

Ah, cool, that's xsprintf working as designed.
Never mind, it's just a compiler warning with -Werror.

[poettering]

Would be good if we'd get a patch for this, as we don't run x32 systems.

[fsateler]

Doesn't #5624 fix this?

cc @glaubitz

[glaubitz]

Yes, it does. We just need to agree in #5624 how to resolve it. I have suggested a patch. Maybe @poettering can comment on this.

[glaubitz]

#5624 has been merged now. Can we close this?

[keszybz]

Yeah, this should be solved now.