nwjs require

[guybedford]

Since we changed to no longer altering the require global during execution, this breaks Node webkit support as they use a global.require there.

We should always scope require to be undefined for SystemJS module execution, with synchronous reversion of the global value for AMD and global formats where we need to trigger the right UMD pattern.

Then in terms of consistency, it's annoying that we have different rules for each format like this one, but it does seem best as that is the nature of handling compatibility cases.

[MikeKovarik]

I would very much like to see this fixed as soon as possible since monkey patching my dependencies like this is driving me crazy

var isNWJS = typeof nw == 'object' && typeof nw.App == 'object';
if (isNWJS) {
    module.exports = global.require('net');
} else {...}

[MikeKovarik]

So I looked into it a bit and found a solution or rather temporal workaround since complexity of SystemJS goes way beyond my understanding. #1168

[guybedford]

Unfortunately the @node namesapce is reserved only for Node core modules itself. I'd suggest something like the following here rather -

System.set('@nwjs/module-x', System.newModule({ default: require('nwjs-module-x') });
global.require = undefined;

Ideally the global require should not be set as that will interfere with global module evaluation.

There is another change that may fix the global require issue here and that would be to move back to using a vm implementation that does encapsulated globals in Node.

Perhaps that is the best fix really, I've created #1183 to track.

[guybedford]

I've added clearing the global scoped require in 8ee8916, pending release.

[guybedford]

Released in 0.19.25.