Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Edge bug #1182

Closed
guybedford opened this issue Mar 26, 2016 · 12 comments
Closed

Investigate Edge bug #1182

guybedford opened this issue Mar 26, 2016 · 12 comments

Comments

@guybedford
Copy link
Member

Posting to track Aurelia's critical bug in Edge. Apparently this can be replicated via the docs site at http://aurelia.io/docs.html#/aurelia/framework/latest/doc/article/what-is-aurelia with devtools closed showing incorrect loading behaviour.

@guybedford
Copy link
Member Author

This is resolved by the implementation of #1070.

The work around is to include <script src="url-polyfill.js"></script> before SystemJS where the file for url-polyfill.js is from https://github.com/ModuleLoader/es6-module-loader/blob/master/src/url-polyfill.js.

@DavidRogers
Copy link

Hi guy, I just tried the workaround you described and it made no difference in Edge... I used the exact polyfill you referenced. I have an Aurelia app using JSPM (which I love btw!)
Am I missing something?

@guybedford
Copy link
Member Author

@DavidRogers that needs to be included as well as the Promise polyfill before SystemJS.

@guybedford
Copy link
Member Author

Released in 0.19.25.

@DavidRogers
Copy link

I forgot to mention that I did have the bluebird Promise polyfill included as well. (And they are both included before SystemJS).

@guybedford
Copy link
Member Author

Can you investigate where in the pipeline it is not working? For example, is the bundle being executed? Does it work with devtools open? Are there errors being thrown Etc etc. There are many possible compatibility issues.

@DavidRogers
Copy link

It is the same aurelia issue (aurelia/framework#227) that is referenced in this issue.The nature of this bug makes it very difficult to debug since everything works fine with devtools open. The referenced issue has a lot of good info in it that is better than what I could provide you.

@michaelmalonenz
Copy link

@DavidRogers @guybedford I experienced the same issue, but after removing Bluebird promises, it starts up as expected - even with decent performance (which is what Bluebird was addressing), so it's some sort of interaction there. I am using jspm v0.16.32 and systemjs v0.19.25

@DavidRogers
Copy link

I can confirm that removing bluebird as @michaelmalonenz suggests does fix the issue.

@DerAlbertCom
Copy link

i can not confirm this. with or without bluebird, if you use .globalResources() in the configuration of aurelia it the application does not startup.

@SamDeBlock
Copy link

Probably related to bug in Edge, see:
aurelia/framework#227 (comment)
and chakra-core/ChakraCore#1415

@sberney
Copy link

sberney commented Apr 25, 2017

I agree with @SamDeBlock . We have been experiencing this issue too. I don't think SystemJS is at fault, but it does seem to provoke the bug. Not that it adds much information, but I just summarized this.

You might consider adding a check on this line along the lines of

if (typeof meta === 'function')
  meta = meta();

Which makes logical sense, but is not something I have tested, and given the suspected nature of this as a bug with Edge, it may not result in proper behavior either.

Edit and rehash: I suspect all the "resolutions" are patternicity.

One more edit: @guybedford You might consider adding this polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants