Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scopes must require trailing / #2007

Closed
guybedford opened this issue Aug 27, 2019 · 3 comments
Closed

Scopes must require trailing / #2007

guybedford opened this issue Aug 27, 2019 · 3 comments

Comments

@guybedford
Copy link
Member

Import maps scopes must have a trailing / in order to properly apply, otherwise they only reference the filename parent.

This is a breaking change we should make with v6.

@guybedford guybedford added the bug label Aug 27, 2019
@guybedford guybedford added this to the 6.0.0 milestone Aug 27, 2019
@joeldenning
Copy link
Collaborator

Are these the relevant lines of code?

systemjs/src/common.js

Lines 135 to 136 in a8d4dc5

if (resolvedScopeName[resolvedScopeName.length - 1] !== '/')
resolvedScopeName += '/';

Are you saying that systemjs should not automatically append the trailing slash anymore, and have a different behavior if an import map doesn't have that trailing slash?

@guybedford
Copy link
Member Author

Yes exactly. Effectively a scope without a trailing slash is just a file.

@guybedford
Copy link
Member Author

Released in 6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants