Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS support #2109

Closed
joeldenning opened this issue Jan 22, 2020 · 4 comments
Closed

NodeJS support #2109

joeldenning opened this issue Jan 22, 2020 · 4 comments

Comments

@joeldenning
Copy link
Collaborator

The single-spa community has some interest in supporting server rendering (single-spa/single-spa#103). Much, but not all, of the single-spa community uses SystemJS, so getting systemjs working in node is becoming a priority for us.

First question to think about, I think, is whether to do fetch + eval on the server or not. Alternative would perhaps be something with cjs / esm that is in the node_modules. My concern with fetch + eval is security of executing arbitrary code from remote servers. But other options don't really seem to be systemjs at all.

@guybedford thoughts?

@guybedford
Copy link
Member

If we get #2058 merged, the implementation here simplifies to just creating a custom fetch hook for Node.js I believe.

I think that may well be the missing piece to make maintaining this straightforward.

@guybedford
Copy link
Member

(and yes I'm all for the feature, it's just been for lack of effort!)

@guybedford
Copy link
Member

Note, this is a duplicate of #1873.

@joeldenning
Copy link
Collaborator Author

Oh I'll close in favor of #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants