Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch-load.js is not ES5 compatible in 6.14.0 #2455

Closed
erikt9 opened this issue Mar 21, 2023 · 3 comments · Fixed by #2456
Closed

fetch-load.js is not ES5 compatible in 6.14.0 #2455

erikt9 opened this issue Mar 21, 2023 · 3 comments · Fixed by #2456

Comments

@erikt9
Copy link
Contributor

erikt9 commented Mar 21, 2023

Last version (6.14.0) introduced non-ES5 code (lines 20 - 24):

return this.fetch(url, {
    credentials: 'same-origin',
    integrity: importMap.integrity[url],
    meta
  })

The meta is not ES5 syntax and makes the distributed bundle non-ES5.
@wenerme
Copy link
Collaborator

wenerme commented Mar 21, 2023

I don't get it, why this makes non-ES5 ?

@erikt9
Copy link
Contributor Author

erikt9 commented Mar 21, 2023 •
edited

The shortcut syntax { meta } is not available in ES5. The code fails ES5 validators. It should be { meta: meta }

@wenerme
Copy link
Collaborator

wenerme commented Mar 21, 2023

Ok, got it

@wenerme wenerme mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid shortcut syntax for es5 wenerme/systemjs
2 participants
@wenerme @erikt9