-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RactiveJS and SystemJS 0.11.2 - Module process not declared as a dependency #322
Comments
Just stumbled across this error as well. Works fine with 0.11.1. |
Thanks, this is due to 3bfddd8. @theefer it seems like reverting to tokenizing may be the way to go with the rules at this level as this is caused by string characters in regular expressions causing invalid string removal. For now we should probably revert the change, and then work on a tokenizer for the next release. |
Sounds fair. Regexp only get us so far. Will the tokeniser run in all cases, or do you want to start the work to |
The tokenizer will just run in browser in dev, to avoid a full syntax parser. Builds use their own parsing process - https://github.com/systemjs/builder/blob/master/compilers/cjs.js. |
OK. Are you thinking of using esprima, or another parser? |
I was thinking simple tokenizing like in Line 49 in 5f46011
|
Ah yes that'd work. Plus I realised today stable esprima doesn't support much of ES6 :-( |
An alternative would be to just use Traceur for CommonJS as well actually, but I'm hesitant. |
Fixed and published the reversion for this as 0.11.3. |
Should the bug whose fix broke this and got reverted be reopened? |
@theefer yes, we can reopen the issue. |
It's #311 but I don't have the rights to reopen. |
After the last update my app stop running:
When I downgrade to version 0.11.1 all back to normal.
The text was updated successfully, but these errors were encountered: