Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cask refactor broke all formulas depending on the plugin formula #12

Closed
capelio opened this issue Dec 10, 2019 · 3 comments
Closed

Cask refactor broke all formulas depending on the plugin formula #12

capelio opened this issue Dec 10, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@capelio
Copy link

capelio commented Dec 10, 2019

Heya @dkanejs. First off, thanks for all the hard work supporting this Brew formula. It's been very useful to be able to depend on it from other formulas.

Unfortunately, with the cask refactor, any new installs of fomulas that depended on the fomula-version of the plugin now fail. I've scoured the Homebrew docs and it's not possible to depend on a cask from a formula. It's also not possible to specify a git hash or tag via depends_on.

Any chance you could re-introduce the formula version of the plugin alongside the cask version?

@Systemmanic Systemmanic self-assigned this Dec 11, 2019
@Systemmanic Systemmanic added the bug Something isn't working label Dec 11, 2019
@Systemmanic
Copy link
Owner

Hey @capelio,

First of all, thanks and apologies for breaking your stuff, wasn't intentional of course.

I had just assumed now it is in Cask that no one would want to go to the trouble of using mine 😆

I will reinstate this plugin back as a brew one asap, I had not considered your use case!

@Systemmanic
Copy link
Owner

Systemmanic commented Dec 11, 2019

I've merged #13 so that's it back in action @capelio

It's on the latest available version now also: 1.1.50.0

I'm happy to maintain this version regardless of the Cask version existing in homebrew-cask, especially if it covers a dependencies use case.

Let me know if that's working for you and we can get this one closed 😄

@Systemmanic
Copy link
Owner

Closing this as I believe this is fixed, feel free to reopen if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants