cli: remove double newline character from _exec_cmd

getpopper · Aug 13, 2020 · 239f964 · 239f964 · edeediong · Aug 14, 2020
1 parent 5874da6
commit 239f964
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/popper/runner_host.py b/src/popper/runner_host.py
@@ -80,9 +80,9 @@ def _exec_cmd(cmd, env=None, cwd=os.getcwd(), pids=set(), logging=True):
                 output = []
                 for line in iter(p.stdout.readline, ""):
                     if logging:
-                        log.step_info(line)
+                        log.step_info(line.rstrip())
                     else:
-                        output.append(line)
+                        output.append(line.rstrip())
 
                 p.wait()
                 ecode = p.poll()

diff --git a/src/test/test_runner_host.py b/src/test/test_runner_host.py
@@ -71,14 +71,14 @@ def test_exec_cmd(self):
         pid, ecode, output = HostRunner._exec_cmd(cmd, logging=False)
         self.assertGreater(pid, 0)
         self.assertEqual(ecode, 0)
-        self.assertEqual(output, "hello-world\n")
+        self.assertEqual(output, "hello-world")
 
         with LogCapture("popper") as logc:
             pid, ecode, output = HostRunner._exec_cmd(cmd)
             self.assertGreater(pid, 0)
             self.assertEqual(ecode, 0)
             self.assertEqual(output, "")
-            logc.check_present(("popper", "STEP_INFO", "hello-world\n"))
+            logc.check_present(("popper", "STEP_INFO", "hello-world"))
 
         cmd = ["env"]
         pid, ecode, output = HostRunner._exec_cmd(