Skip to content

Commit

Permalink
cli: tweak installer to allow spaces in step IDs (#897)
Browse files Browse the repository at this point in the history
For the script that gets generated by the installer, the call to `docker`
must receive the command-line arguments verbatim, including
quotes. Therefore `$@` needs to be quoted.

Without quotes (before):
$ popper run -f wf.yml "first step"
would execute:
$ docker run <...> getpopper/popper:v2.7.0 run -f wf.yml first step

With quotes (after fix):
$ docker run <...>  getpopper/popper:v2.7.0 run -f wf.yml "first step"

[skip ci]
  • Loading branch information
wtraylor committed Jul 29, 2020
1 parent 753fd71 commit 4098bc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ docker run --rm -ti \
--volume "$PWD":"$PWD" \
--workdir "$PWD" \
--env-file /tmp/.envfile \
getpopper/popper:v2.7.0 $@
getpopper/popper:v2.7.0 "$@"
EOF

if [ "$?" -eq 0 ]; then
Expand Down

0 comments on commit 4098bc3

Please sign in to comment.