Error message for empty workflow file (#809) (#833)

fixes #809
getpopper · May 19, 2020 · e739b60 · e739b60
1 parent 5e17323
commit e739b60
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/cli/popper/parser.py b/cli/popper/parser.py
@@ -80,6 +80,9 @@ def parse(
 
             with open(file, "r") as f:
                 _wf_data = yaml.safe_load(f)
+
+                if not _wf_data:
+                    log.fail(f"File {file} is empty")
         else:
             _wf_data = wf_data
 

diff --git a/cli/test/test_parser.py b/cli/test/test_parser.py
@@ -14,6 +14,17 @@ def setUp(self):
     def tearDown(self):
         log.setLevel("NOTSET")
 
+    def test_empty_file(self):
+        try:
+            f = open("test.yml", "a")
+            f.close()
+            WorkflowParser.parse(file="test.yml")
+            self.assertTrue(False, "Empty Workflow file does not raise an exception.")
+        except SystemExit:
+            self.assertTrue(True)
+        else:
+            self.assertTrue(False, "Empty Workflow file does not raise a SystemExit.")
+
     def test_new_workflow(self):
         wf_data = {}
         self.assertRaises(SystemExit, WorkflowParser.parse, **{"wf_data": wf_data})