Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: extend 'uses' keyword for action blocks to handle any Git repo (as opposed to just Github's) #483

Closed
ivotron opened this issue Feb 12, 2019 · 5 comments

Comments

@ivotron
Copy link
Collaborator

ivotron commented Feb 12, 2019

Extend the uses keyword of action blocks so that users can provide arbitrary Git URLs. The format would be:

{url}/{user}/{repo}@{ref}

or

{url}/{user}/{repo}/{path}@{ref}
@ivotron ivotron changed the title cli: create abstraction for interacting with SCMs cli: create abstraction for interacting with SCM services Feb 16, 2019
@eltrufas
Copy link
Contributor

Using these REST APIs might require defining some place to save auth details for these. Probably somewhere separate from popper.yml since you probably don't want these sitting in plain text in version control.

@ivotron ivotron changed the title cli: create abstraction for interacting with SCM services cli: create abstraction for interacting with SCM web services Feb 21, 2019
@ivotron
Copy link
Collaborator Author

ivotron commented Feb 21, 2019

@eltrufas thanks for the feedback! At some point the popper archive implemented the functionality where it would store this in a file locally in the repo and put the name of that file in .gitignore. We'd need to go back on the commit history to look for this

@ivotron
Copy link
Collaborator Author

ivotron commented Mar 4, 2019

Gave this a bit more of thought, I've updated the title and description as a result. It simplifies things as we don't need to use a REST API anymore (we do everything through Git)

@ivotron ivotron changed the title cli: create abstraction for interacting with SCM web services cli: extend 'uses' keyword for action blocks to handle any Git repo (as opposed to just Github's) Mar 4, 2019
@barbaraDorame
Copy link
Contributor

Hey ivo, i have an issue, im not sure how to handle urls from different services. Before we could do user/repo/dir-path but now im not sure how to handle a generic git url without breaking back compatibility.

Here is my code: https://github.com/barbaraDorame/popper/tree/issue-483

Thanks in advance!

@ivotron
Copy link
Collaborator Author

ivotron commented Mar 13, 2019

hey @barbaraDorame , I left some comments on barbaraDorame@ac75e00 . Please take a look

ivotron pushed a commit that referenced this issue May 24, 2020
Extends the interpretation of the 'uses' attribute of action blocks so that other Git URLs besides those pointing to Github are allowed.

fixes #483
ivotron pushed a commit that referenced this issue May 25, 2020
Extends the interpretation of the 'uses' attribute of action blocks so that other Git URLs besides those pointing to Github are allowed.

fixes #483
ivotron pushed a commit that referenced this issue May 25, 2020
Extends the interpretation of the 'uses' attribute of action blocks so that other Git URLs besides those pointing to Github are allowed.

fixes #483
ivotron pushed a commit that referenced this issue May 25, 2020
Extends the interpretation of the 'uses' attribute of action blocks so that other Git URLs besides those pointing to Github are allowed.

fixes #483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants