Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #508 Adds singularity runner #552

Merged
merged 11 commits into from
Mar 26, 2019

Conversation

JayjeetAtGithub
Copy link
Collaborator

Adds a SingularityRunner class in gha.py to run singularity based action.

@pep8speaks
Copy link

pep8speaks commented Mar 21, 2019

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-26 15:04:12 UTC

@JayjeetAtGithub
Copy link
Collaborator Author

@ivotron This pr is not yet ready for reviewing.

@JayjeetAtGithub JayjeetAtGithub force-pushed the jayjeet/singularity_runner branch 3 times, most recently from 853ed25 to a7e0edb Compare March 25, 2019 08:15
@JayjeetAtGithub
Copy link
Collaborator Author

@ivotron This PR is ready for initial review. Please suggest me changes that i might have missed. Thanks !

@JayjeetAtGithub
Copy link
Collaborator Author

JayjeetAtGithub commented Mar 26, 2019

@ivotron Updated the tests ! Please have a look ! Thanks

@JayjeetAtGithub
Copy link
Collaborator Author

@ivotron The tests have actually passed , but its showing pending to me ? Please open this to see the logs. Cant understand why this is happening ?

@ivotron ivotron merged commit d89359c into getpopper:master Mar 26, 2019
@ivotron
Copy link
Collaborator

ivotron commented Mar 26, 2019

thanks a lot!

@JayjeetAtGithub JayjeetAtGithub deleted the jayjeet/singularity_runner branch August 18, 2019 20:01
ivotron pushed a commit that referenced this pull request May 24, 2020
Adds singularity action runner

fixes #508
ivotron pushed a commit that referenced this pull request May 25, 2020
Adds singularity action runner

fixes #508
ivotron pushed a commit that referenced this pull request May 25, 2020
Adds singularity action runner

fixes #508
ivotron pushed a commit that referenced this pull request May 25, 2020
Adds singularity action runner

fixes #508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants