Fixes #564 Implements popper add

[JayjeetAtGithub]

Implements the popper add command. On doing popper add cplee/github-actions-demo , the repository is cloned, the main.workflow file searched, scanned, copied to project_root and then the toplevel folder of local actions are also copied which are identified by parsing the workflow.

[pep8speaks]

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-09 06:09:22 UTC

[JayjeetAtGithub]

@ivotron Please have a look !

[ivotron]

thanks @JayjeetAtGithub! The main idea is to use git to clone the repo and copy the workflow file, along with any locally-defined action that the workflow is referring to.

[JayjeetAtGithub]

@ivotron Got it ! Will be updating soon.

[JayjeetAtGithub]

@ivotron
When we can refer to reuse using ./test in uses.

action "test reuse" {
  uses = "./test"
  runs = "reuse"
}

So, why do we use

action "test reuse" {
  uses = "./ci/test"
  runs = "reuse"
}

This ought to be had asked before, but somehow my eyes couldn't catch it ?
Can you please help me understand this ?

Without having this cleared, i couldnt understand how to copy the actions. Thanks

[ivotron]

sure. References in a uses attribute of a .workflow file are relative to the root of the project. So if a workflow file is in /project/path/containing/main.workflow and there is an action in /project/another/path/to/an/action that the workflow needs, it will reference it by doing ./another/path/to/an/action. In the example you wrote, the action is defined in ./ci/test, which is a container-less action executed by the HostRunner class.

The runs attribute of an action block are references to commands within the action. In the example you gave, it is referring to the reuse command (defined in ./ci/test/reuse).

ihth

[JayjeetAtGithub]

@ivotron This is ready for review.

[ivotron]

thanks a lot @JayjeetAtGithub, this is looking great! Please take a look at the comments

[JayjeetAtGithub]

@ivotron I have made the changes. Please have a look.
We can now do popper add github.com/cplee/github-actions-demo@develop,
popper add gitlab.com/cplee/github-actions-demo/.github@develop etc.

[ivotron]

thanks @JayjeetAtGithub !

[JayjeetAtGithub]

@ivotron Updated it. Please have a look !

[JayjeetAtGithub]

@ivotron test interrupt is failing sometimes and only for python3.7. Can you please check it once.

[ivotron]

@JayjeetAtGithub can you please rebase master? I made some changes to ctrl-c and test interrupt

[JayjeetAtGithub]

@ivotron rebased..Please check

[ivotron]

thanks @JayjeetAtGithub! please take a look at the comments

[ivotron]

thanks!