Fixed popper dot command #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivotron
requested changes
Apr 26, 2019
There was a problem hiding this comment.
thanks a lot @JayjeetAtGithub , please take a look at the comments
ci/test/dot
Outdated
| @@ -9,7 +9,7 @@ cd "$test_repo_path" | |||
| git clone https://github.com/cplee/github-actions-demo.git | |||
| cd github-actions-demo | |||
|
|
|||
| export PHONY_SECRET=foo | |||
| # export PHONY_SECRET=foo | |||
There was a problem hiding this comment.
we can delete these lines, as popper dot won't prompt for secrets anymore
cli/popper/gha.py
Outdated
| @@ -19,7 +19,7 @@ class Workflow(object): | |||
| """ | |||
|
|
|||
| def __init__(self, wfile, workspace, dry_run, | |||
| reuse, parallel): | |||
| reuse, parallel, no_prompt=False): | |||
There was a problem hiding this comment.
maybe rename to no_secrets_prompt or skip_secrets_prompt?
not sure either... hmm, maybe a transient issue? |
|
@ivotron Somehow the arrangement of imports again got disturbed, so fixed that. |
ivotron
approved these changes
Apr 28, 2019
ivotron
pushed a commit
that referenced
this pull request
May 24, 2020
thanks a lot @JayjeetAtGithub! fixes #610
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
thanks a lot @JayjeetAtGithub! fixes #610
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
thanks a lot @JayjeetAtGithub! fixes #610
ivotron
pushed a commit
that referenced
this pull request
May 25, 2020
thanks a lot @JayjeetAtGithub! fixes #610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more prompts for
secretsduringpopper dot.