Blacklist/whitelist workflows via git commit messages #659
Conversation
|
Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-05-30 14:15:34 UTC |
JayjeetAtGithub
force-pushed
the
jayjeet/blacklist
branch
2 times, most recently
from
870aad9
to
c881423
Compare
|
@ivotron Can you please explain how to deal with merge commits ? Thanks |
cli/popper/commands/cmd_run.py
Outdated
|
|
||
| if 'Merge' in msg: | ||
| log.info("Merge detected. Reading message from merged commit.") | ||
| commit_id = re.search(r'Merge (.+?) into', msg).group(1) |
There was a problem hiding this comment.
a merge commit is a "meta-commit" that describes a commit commit A being merged into B. For example, this one. The idea is to obtain the message for A, which is the commit that is being merged, and process it so that we know whether there are any workflows being white/black listed. Since we are now using GitPython, we might be able to use it to obtain this information (as opposed to using regular expressions.
JayjeetAtGithub
changed the title
JayjeetAtGithub
changed the title
JayjeetAtGithub
force-pushed
the
jayjeet/blacklist
branch
from
499ec44
to
cb9937c
Compare
JayjeetAtGithub
force-pushed
the
jayjeet/blacklist
branch
from
6a969ea
to
f85a364
Compare
|
@ivotron Please review. Thanks. |
|
awesome! Thanks a lot! |
Adds the ability to blacklist/whitelist which workflows to execute based on keywords found in a Git commit message. fixes #565
Adds the ability to blacklist/whitelist which workflows to execute based on keywords found in a Git commit message. fixes #565
Adds the ability to blacklist/whitelist which workflows to execute based on keywords found in a Git commit message. fixes #565
Adds the ability to blacklist/whitelist which workflows to execute based on keywords found in a Git commit message. fixes #565
Addresses #565