-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements popper search and info subcommands #674
Conversation
cli/popper/utils.py
Outdated
""" | ||
base_dir = os.path.dirname(__file__) | ||
with open(os.path.join( | ||
base_dir, 'resources/.search_sources.yml'), 'r') as sf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can download the file from github instead so that the popper search
command is not tied to a particular version of popper. In this way, if say a user installs popper 2.5.0, and the list keeps evolving, then the same version of popper can be used
Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-06-12 19:04:38 UTC |
4c13288
to
29deb1d
Compare
29deb1d
to
bd6e8b2
Compare
No description provided.