Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation function to validate Update Profile request body #107

Merged

Conversation

isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Jul 20, 2018

Description

  • Added a validation function to validate request data sent for PUT /user API.
  • Added a lot of tests for each new function added.
  • Added new utils functions to avoid mistakes in the future regarding the string used for length validation errors
  • Added utils to strip strings before checking their length
  • Allow usernames to contain "_"

Fixes #96
Fixes #97

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Created a lot of tests for validation functions and api, and did a quick test on Swagger UI

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@r00pal r00pal merged commit 432ff21 into anitab-org:gsoc18-code Jul 24, 2018
@isabelcosta isabelcosta added the Program: GSOC Related to work completed during the Google Summer of Code Program. label Aug 9, 2018
GeVic pushed a commit to GeVic/mentorship-backend that referenced this pull request Aug 13, 2018
@isabelcosta isabelcosta deleted the fix-update-data-validation branch December 30, 2018 01:52
b-thebest pushed a commit to b-thebest/mentorship-backend that referenced this pull request Mar 2, 2021
RiddhiAthreya pushed a commit to RiddhiAthreya/mentorship-backend that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants