New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to read environment variables #51
Add support to read environment variables #51
Conversation
d12f182
to
f3c89ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isabelcosta
please include a sample .env
file in the repo.
In readme.md
write the steps that the user will need to follow to update the .env
file.
Lastly, include the .env file in the .gitignore
file.
Also, remove the sample |
the Instead, should I create a file such as |
Will explain this in the 1:1 |
f3c89ec
to
d375714
Compare
@m-murad changes to the README.md file done |
Description
SECRET_KEY
andENVIRONMENT_CONFIGURATION
from environment variables;.env
file;dev
,test
orprod
;test_app_config.py
according to changes.With these changes, we can set sensitive data on the
.env
file and import them without hardcoding it on the codeFixes #21
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
test_config_app.py
(fixed tests according to this change).env
file with exported with different types of configurations, to test if the app only accepteddev
,test
andprod
how it shouldChecklist:
Code/Quality Assurance Only