Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Application Factory pattern #57

Merged

Conversation

isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Jun 24, 2018

Description

  • Applied Application Factory pattern, which does lazy initialization for the flask extensions, and allows to create the application with a single function create_app()
  • This function is used while running the app, and when setting up API testing
  • Fixed imports

Fixes #55

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I ran the application with python run.py
  • I created a test for POST /register which worked as expected

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Dilu9218 Dilu9218 merged commit a5136a9 into anitab-org:gsoc18-code Jun 27, 2018
@isabelcosta isabelcosta deleted the application-factory-pattern branch July 5, 2018 20:30
@isabelcosta isabelcosta added the Program: GSOC Related to work completed during the Google Summer of Code Program. label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants