Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept mentorship request API #58

Merged

Conversation

isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Jun 24, 2018

Description

  • Created API to accept a mentorship request
  • Created test for DAO class
  • Created test for API

Fixes #12

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Created tests for the DAO object and ran all the tests (new and old ones)
Tested on Swagger UI, with 3 different users, and a mentorship request sent by user 1 to user 2.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Update Swagger documentation and the exported file at /docs folder

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@isabelcosta isabelcosta force-pushed the accept-mentorship-request branch 2 times, most recently from 28cdd83 to e80277d Compare June 27, 2018 22:11
@Dilu9218 Dilu9218 merged commit bc2abb2 into anitab-org:gsoc18-code Jun 28, 2018
@isabelcosta isabelcosta deleted the accept-mentorship-request branch July 15, 2018 16:55
@isabelcosta isabelcosta added the Program: GSOC Related to work completed during the Google Summer of Code Program. label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants