-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete mentorship request API #73
Delete mentorship request API #73
Conversation
Will fix the endpoint according to @m-murad suggestion:
|
e05e922
to
30d3765
Compare
5f93d90
to
9df8203
Compare
|
||
request = MentorshipRelationModel.find_by_id(request_id) | ||
|
||
# verify if request exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a good practice to avoid comments that include "what" a code line is doing rather that "why" a code line is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Dilu9218! In the future for this case should I avoid these comments at all or does this code need a "why"?
Description
I developed the API to delete a mentorship request:
DELETE /mentorship_relation/{id}
With these constraints:
Fixes #65
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
delete_request
function. Its tests if the request is deleted or not from the database.Checklist:
Code/Quality Assurance Only