Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Upgraded navbar as per Branding Guidelines #423

Merged
merged 2 commits into from
Jul 21, 2018
Merged

Upgraded navbar as per Branding Guidelines #423

merged 2 commits into from
Jul 21, 2018

Conversation

abhi20161997
Copy link
Contributor

@abhi20161997 abhi20161997 commented Jun 26, 2018 •
edited
Loading

Description

Upgraded navbar as per branding Guidelines

Fixes #422

Mocks

Before :
screenshot from 2018-06-26 15-26-30

After :
screenshot from 2018-06-26 15-27-32

Type of Change:

  • Code
  • User Interface

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@anitab-org anitab-org deleted a comment Jun 26, 2018
@abhi20161997
Copy link
Contributor Author

@Sa7i @yatna Please can you review this ?

yatna
yatna previously approved these changes Jul 2, 2018
View reviewed changes
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.666% when pulling c62106f on abhi20161997:navbar into fd9d9f3 on systers:develop.

@abhi20161997 abhi20161997 added Priority: HIGH Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jul 10, 2018
contactvaibhavi
contactvaibhavi approved these changes Jul 18, 2018
View reviewed changes
Copy link

@contactvaibhavi contactvaibhavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yatna yatna merged commit 97f6d94 into anitab-org:develop Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yatna yatna yatna approved these changes

@contactvaibhavi contactvaibhavi contactvaibhavi approved these changes

@poojithansl poojithansl Awaiting requested review from poojithansl

Assignees
No one assigned
Labels
Category: User Interface Improvements or additions to design. Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhi20161997 @coveralls @yatna @contactvaibhavi