Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Compile errors in the code #1291

Open
3 tasks
thisum opened this issue Aug 7, 2018 · 5 comments
Open
3 tasks

Compile errors in the code #1291

thisum opened this issue Aug 7, 2018 · 5 comments

Comments

@thisum
Copy link
Contributor

thisum commented Aug 7, 2018

As a tester, I should be able to compile the code without any errors

screen shot 2018-08-08 at 11 23 01 am

when replacing the db handler functions, although the DatabaseHandler class is removed from the project, it's usages are not removed.

Acceptance Criteria

  • there shouldn't be any compile errors

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

0.5 hours

@imashwani
Copy link

I have encountered/reproduced this error.
I got the following error

powerup/systers/com/MapActivity.java  
error: package powerup.systers.com.db does not exist  
error: cannot find symbol class DatabaseHandler  
error: cannot find symbol class DatabaseHandler  
error: cannot find symbol class DatabaseHandler  

Since roomDB is being used for database query so somebody might have deleted DatabaseHandler class as it was not needed.

Here I can rewrite the activity to make use of roomDB. Can I takeup this task?

@imashwani
Copy link

imashwani commented Dec 8, 2018

I have checked that the code in master branch doesnot use this activity(powerip.syster.com.MapActivity) anywhere in the project hence we can delete it. Should i do this and make a PR?

@geekanamika
Copy link
Contributor

@imashwani Error is in MapActivityTest class. You're right that DatabaseHandler is deleted without changing the unit tests.
In PR, You will need re-write tests according to current MapActivity implementation.
Can you do it?

@imashwani
Copy link

I have rechecked and from what i understand, on the master branch the MapActivity (powerip.syster.com.MapActivity) is of no use anymore.

There is no associated layout file. The new map layout is gamemap.xml
powerip.syster.com.MapActivity hasn't been used anywhere in the code insted powerup.systers.com.ui.MapActivity is being used with gamemap.xml

I don't know how to write unit tests, can you please guide me on that.
So, I will delete powerip.syster.com.MapActivity and write unit tests for powerup.systers.com.ui.MapActivity in my PR. Thanks for the reply.

@geekanamika
Copy link
Contributor

@m-murad @Rimjhim28 Can I work on this issue? I'll rewrite the tests as per new code changes made during GSoC using Junit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants