Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Include margins for scenario description #552

Closed
Rimjhim28 opened this issue Nov 26, 2017 · 15 comments
Closed

Include margins for scenario description #552

Rimjhim28 opened this issue Nov 26, 2017 · 15 comments

Comments

@Rimjhim28
Copy link
Contributor

Rimjhim28 commented Nov 26, 2017

Description

Currently the scenario description in all the scenarios seems too much aligned to top left corner of the device screen. A better option would be to include margin or padding for a better view.

Mocks

screenshot_1511675724

Acceptance Criteria

There should inclusion of margins for the mentioned text

Definition of Done

Approval by mentors

Estimation

1 hour

@MKDEVELOPEMENT
Copy link
Contributor

can I claim this task

@Rimjhim28
Copy link
Contributor Author

@MKDEVELOPEMENT You need to claim it on GCI portal first.

@MKDEVELOPEMENT
Copy link
Contributor

i have claimed it on GCI

@Rimjhim28
Copy link
Contributor Author

Then you can proceed @MKDEVELOPEMENT

@mofetej
Copy link

mofetej commented Dec 4, 2017

How do i claim the issue here. I already claimed the task on GCI portal

@ZidBidBee
Copy link

Is is possible for me to still claim this task? Even though someone else has claimed it.

@Rimjhim28
Copy link
Contributor Author

@mofetej You just need to inform that you are working on this issue. If you have claimed it on GCI portal you can go ahead.

@Rimjhim28
Copy link
Contributor Author

@ZidBidBee If you can claim it on GCI portal,that is, if the related task is available on GCI portal you can claim it there. If you can claim the task there you can claim the issue.

@yuyuan-luo
Copy link

I would like to work on this, I claimed it on the GCI portal. Thank you! :)

@m-sameer
Copy link
Contributor

m-sameer commented Dec 5, 2017

I'm working on it.

m-sameer added a commit to m-sameer/powerup-android that referenced this issue Dec 5, 2017
m-sameer added a commit to m-sameer/powerup-android that referenced this issue Dec 5, 2017
@m-sameer
Copy link
Contributor

m-sameer commented Dec 5, 2017

@Rimjhim28 I have added the margins, please review the PR.

m-sameer added a commit to m-sameer/powerup-android that referenced this issue Dec 6, 2017
@m-sameer
Copy link
Contributor

m-sameer commented Dec 6, 2017

@Rimjhim28 I have also added all the screenshots in the PR.

@vatsalkul
Copy link
Member

I have added margins to the scenario description. #657

@AryamanAgrawal
Copy link
Contributor

Added the necessary margins with the revised changes. #649

@Rimjhim28
Copy link
Contributor Author

Appropriate PR #603 has been merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants