Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Sink to swim game #113

Merged
merged 7 commits into from
Jul 24, 2017
Merged

Sink to swim game #113

merged 7 commits into from
Jul 24, 2017

Conversation

identity2
Copy link
Contributor

@identity2 identity2 commented Jul 13, 2017

Completed the Sink to Swim game prototype with changes discussed last meeting:

  • Timer now counts down.
  • Boat now has a wobbling animation
  • Score now has a simpler mechanic
  • The game now has an ending scene.

To test the game, choose Library Scenario. All the endings lead to Sink to Swim game.

Copy link
Contributor

@sunjunkie sunjunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit looks good. Just need to resolve the conflict.

@identity2
Copy link
Contributor Author

Solved conflicts.

@jenpaff
Copy link
Contributor

jenpaff commented Jul 18, 2017

I found that when completing the game the total score isn't showing at the end. Can you try if thats working for you please?

@identity2
Copy link
Contributor Author

@jenpaff Seems like I accidentally mistyped a variable. It is fixed now.

@jenpaff
Copy link
Contributor

jenpaff commented Jul 19, 2017

Ok Great- the rest looked good ! I will test the changes again

Copy link
Contributor

@jenpaff jenpaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good now. PR is ready for merging.

@jenpaff jenpaff merged commit 8f81c94 into anitab-org:GSoC17 Jul 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants