This repository has been archived by the owner on May 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neLabel class since SpriteKit has no default multiline labels.
…n successfully load the images.
sunjunkie
suggested changes
Jul 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit looks good. Just need to resolve the conflict.
Solved conflicts. |
sunjunkie
approved these changes
Jul 18, 2017
I found that when completing the game the total score isn't showing at the end. Can you try if thats working for you please? |
@jenpaff Seems like I accidentally mistyped a variable. It is fixed now. |
Ok Great- the rest looked good ! I will test the changes again |
jenpaff
approved these changes
Jul 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, looks good now. PR is ready for merging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed the Sink to Swim game prototype with changes discussed last meeting:
To test the game, choose Library Scenario. All the endings lead to Sink to Swim game.