Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Adding selenium tests #349

Closed
wants to merge 7 commits into from
Closed

Conversation

smarshy
Copy link
Contributor

@smarshy smarshy commented Jun 24, 2016

This PR is to add remaining tests from last week as well as the tests for this week. I am putting a separate PR so that it is easier to review. The tests include -

  • test for job details
  • 3 tests for shift details view (due to 3 test situations : when no volunteers are registered for a shift, when volunteers are registered but haven't logged hours and when hours are logged)
  • 3 tests for checking that values in event, shift and job form are not lost when the page reloads
  • test for checking if a shift can have 0 volunteers (validating max volunteer field)
  • test to check that logged hours fall between the shift hours
  • test for simplify shift

In addition to this, there are 3 more tests which have been commented out:

  • 2 tests for checking that event is unique and job within event is unique. These have been commented out as the feature hasn't been implemented yet ( Job name inside an event should be unique #330 and Events name has to be unique #329 )
  • test for simplify job (This test is not passing; I think the reason is because the js script is not updating the date in the form. i tried increasing delay but it sill doesn't seem to work)

Total tests that would run are143 ( 133 original + 10 new + 3 commented out)
Related to issue #346

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 94.082% when pulling 56ee2b0 on smarshy:add-tests-2 into fcfb5c5 on systers:develop.

@@ -4,7 +4,7 @@
from django.contrib.auth.models import User
from administrator.models import Administrator
from volunteer.models import Volunteer
from organization.models import Organization #hack to pass travis,Bug in Code
from organization.models import Organization # hack to pass travis,Bug in Code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if I remove this?

@tapaswenipathak
Copy link
Contributor

tapaswenipathak commented Jun 27, 2016

test for simplify job (This test is not passing; I think the reason is because the js script is not updating the date in the form. i tried increasing delay but it sill doesn't seem to work)

I will try reproducing it. Which JS script you are referring to, here? Did you try without including the date part? How much delay did you give?

@tapaswenipathak
Copy link
Contributor

@smarshy This has conflicts now. Can you please resolve them?

@smarshy smarshy closed this Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants