Hide textbox for resume link if resume file is uploaded in sign up form #625

anjali-dhanuka · 2018-02-16T06:47:01Z

Description

The textbox for resume link hides if volunteer uploads a resume file.

Fixes #624

Type of Change:

Code

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

anjali-dhanuka · 2018-02-16T06:47:23Z

@tonythomas01 @tapasweni-pathak Please review.

coveralls · 2018-02-16T06:48:55Z

Coverage remained the same at 42.435% when pulling d09ec6a on anjali-dhanuka:hide_resume into 39285b6 on systers:develop.

anjali-dhanuka · 2018-02-17T13:22:54Z

@tapasweni-pathak @tonythomas01 Rectified the operator Please review.

tonythomas01 · 2018-02-17T14:05:36Z

vms/vms/static/vms/js/hide_resume.js

@@ -0,0 +1,9 @@
+$(document).ready(function() {
+    $("input[type='file']").change(function() {
+    var FileLength = $("#id_vol-resume_file")[0].files.length;


variable names in JS follows camelCase

Also, I wouldnt name it hide_resume as its actually hide_resume_textbox - minor though.

@tonythomas01 Done with the changes you suggested. Can you please review.

tonythomas01 · 2018-02-17T14:07:53Z

vms/vms/static/vms/js/hide_resume.js

+$(document).ready(function() {
+    $("input[type='file']").change(function() {
+    var FileLength = $("#id_vol-resume_file")[0].files.length;
+    if (FileLength!==0){


better use http://api.jquery.com/toggle/?

Yes toggle is better to use, implemented this too. Have a look.

anjali-dhanuka · 2018-02-23T15:56:54Z

@tapasweni-pathak @tonythomas01 @prachi1210 Done with the changes.
Please review.

abarya · 2018-03-02T19:13:30Z

Hi @anjali-dhanuka, I was reviewing your PR. You worked really well. But, I think there is a bug that needs some fix. Here it is.
When I uploaded a file for the first time, then the webpage looks like this:

Then, I decide to upload a newer resume instead of this one. Now see, what happens:

@anjali-dhanuka, Please fix this.

@tonythomas01, Can you confirm this behaviour?

anjali-dhanuka · 2018-03-05T18:32:23Z

@abhishekarya286 Yes I see that. I'll fix that.

abarya · 2018-03-11T05:42:47Z

Hi @anjali-dhanuka, Any updates?

anjali-dhanuka · 2018-03-12T06:01:05Z

Sorry for the late response! Got busy in some other work. Will do it shortly.

anjali-dhanuka · 2018-04-03T20:31:22Z

@abhishekarya286 @m-murad @tonythomas01 @ramitsahwney27 Sorry for the delay, I have solved the issue. Please review.

abarya · 2018-04-10T18:19:34Z

LGTM. Thanks for your contribution. @prachi1210 please merge this.

ayushgarg1804 · 2018-04-25T21:28:12Z

Please add corresponding tests.

kamsuri · 2018-05-12T18:04:53Z

Submitted code is working absolutely fine but the coverage is decreased, @anjali-dhanuka please look into it, write corresponding tests.

anjali-dhanuka · 2018-05-12T22:28:32Z

@kamsuri The tests have been commented out currently, @Monal5031 needs to work on them before I can write new tests.

Monal5031 · 2018-05-12T22:37:19Z

@anjali-dhanuka Please check if the PRs need selenium integrated or not. If not needed i.e. they can be tested without selenium please try to do so.

kamsuri · 2018-05-13T04:44:56Z

Also, please squash the commits.

js file created name of js file corrected operator corrected changes done filename changed filename url changed reload issue solved changes implemented alert removed

anjali-dhanuka · 2018-05-13T12:02:21Z

@kamsuri Done with the squashing. Please review

kamsuri

The code is correct but as it was decided in last meeting that we won't be merging PRs wihtout tests.

anjali-dhanuka · 2018-05-16T06:53:28Z

@Monal5031 Can u please guide me how to check that.

Monal5031 · 2018-05-16T14:11:47Z

@anjali-dhanuka Check if your enhancements require the verification of content of the rendered template or just loading the page headers and status codes(200,404,403) would suffice.
You will have to use selenium for first part and later can be done via unit testing.

anjali-dhanuka · 2018-05-19T07:54:14Z

@Monal5031 It needs to check the content.

Monal5031 · 2018-05-19T12:55:48Z

Okay no problem, 2nd PR is in review after which you'll be able to add tests. 🎉

tonythomas01 · 2018-05-20T17:24:21Z

vms/registration/templates/registration/signup_volunteer.html

@@ -374,7 +374,7 @@ <h2>{% trans "Sign Up" %}</h2>
                </div>
            </div>
        {% endif %}
-        <div id="div_id_resume_file" class="form-group">
+        <div id="div_id_resume_file" class="form-group" onchange="hide_resume_textbox()">


js functions, please no underscores. better hideResumeTextBox() ?

tonythomas01 · 2018-05-20T17:24:40Z

vms/vms/static/vms/js/hide_resume_textbox.js

+if (fileLength!==0){
+$("#div_id_resume").hide();}
+else
+{$("div_id_resume").show();}


.toggle() please.

tonythomas01 · 2018-05-20T17:24:58Z

vms/vms/templates/vms/base.html

@@ -24,6 +24,7 @@
    <script src="{% static "vms/jquery-ui-1.11.4.custom/jquery-ui.min.js" %}"></script>
    <script src="{% static "vms/jquery-custom/activate-datepicker.js" %}"></script>
    <script src="{% static "vms/datetimepicker/bootstrap-datetimepicker.min.js" %}"></script>
+    <script src="{% static "vms/js/hide_resume_textbox.js" %}"></script>


hide-reseume-textbox.js

mayburgos · 2018-07-23T15:44:56Z

@anjali-dhanuka is sending a new PR to gsoc18-code branch.

anitab-org deleted a comment Feb 17, 2018

tonythomas01 suggested changes Feb 17, 2018

View reviewed changes

resume textbox hidden

d09ec6a

js file created name of js file corrected operator corrected changes done filename changed filename url changed reload issue solved changes implemented alert removed

anjali-dhanuka force-pushed the hide_resume branch from c4ae75b to d09ec6a Compare May 13, 2018 12:01

kamsuri approved these changes May 15, 2018

View reviewed changes

tonythomas01 reviewed May 20, 2018

View reviewed changes

mayburgos added the Program: GSOC Related to work completed during the Google Summer of Code Program. label Jul 10, 2018

mayburgos assigned abarya, kamsuri and nida Jul 16, 2018

mayburgos added Program: GSOC Related to work completed during the Google Summer of Code Program. and removed Program: GSOC Related to work completed during the Google Summer of Code Program. labels Jul 16, 2018

mayburgos closed this Jul 23, 2018

mayburgos unassigned nida Feb 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide textbox for resume link if resume file is uploaded in sign up form #625

Hide textbox for resume link if resume file is uploaded in sign up form #625

anjali-dhanuka commented Feb 16, 2018 •

edited

anjali-dhanuka commented Feb 16, 2018

coveralls commented Feb 16, 2018 •

edited

anjali-dhanuka commented Feb 17, 2018

tonythomas01 Feb 17, 2018

tonythomas01 Feb 17, 2018

anjali-dhanuka Feb 23, 2018

tonythomas01 Feb 17, 2018

anjali-dhanuka Feb 23, 2018

anjali-dhanuka commented Feb 23, 2018

abarya commented Mar 2, 2018

anjali-dhanuka commented Mar 5, 2018

abarya commented Mar 11, 2018

anjali-dhanuka commented Mar 12, 2018

anjali-dhanuka commented Apr 3, 2018

abarya commented Apr 10, 2018

ayushgarg1804 commented Apr 25, 2018 •

edited

kamsuri commented May 12, 2018

anjali-dhanuka commented May 12, 2018

Monal5031 commented May 12, 2018

kamsuri commented May 13, 2018

anjali-dhanuka commented May 13, 2018

kamsuri left a comment

anjali-dhanuka commented May 16, 2018

Monal5031 commented May 16, 2018

anjali-dhanuka commented May 19, 2018

Monal5031 commented May 19, 2018

tonythomas01 May 20, 2018

tonythomas01 May 20, 2018

tonythomas01 May 20, 2018

mayburgos commented Jul 23, 2018

Hide textbox for resume link if resume file is uploaded in sign up form #625

Hide textbox for resume link if resume file is uploaded in sign up form #625

Conversation

anjali-dhanuka commented Feb 16, 2018 • edited

Description

Type of Change:

How Has This Been Tested?

Checklist:

anjali-dhanuka commented Feb 16, 2018

coveralls commented Feb 16, 2018 • edited

anjali-dhanuka commented Feb 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anjali-dhanuka commented Feb 23, 2018

abarya commented Mar 2, 2018

anjali-dhanuka commented Mar 5, 2018

abarya commented Mar 11, 2018

anjali-dhanuka commented Mar 12, 2018

anjali-dhanuka commented Apr 3, 2018

abarya commented Apr 10, 2018

ayushgarg1804 commented Apr 25, 2018 • edited

kamsuri commented May 12, 2018

anjali-dhanuka commented May 12, 2018

Monal5031 commented May 12, 2018

kamsuri commented May 13, 2018

anjali-dhanuka commented May 13, 2018

kamsuri left a comment

Choose a reason for hiding this comment

anjali-dhanuka commented May 16, 2018

Monal5031 commented May 16, 2018

anjali-dhanuka commented May 19, 2018

Monal5031 commented May 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayburgos commented Jul 23, 2018

anjali-dhanuka commented Feb 16, 2018 •

edited

coveralls commented Feb 16, 2018 •

edited

ayushgarg1804 commented Apr 25, 2018 •

edited