-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf(server): Redis接続をストリーミング接続ごとに作らず、プロセス全体で共有するように
- Loading branch information
Showing
2 changed files
with
13 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これこうして良いんだっけ?というのが自信ない(コネクション使いまわすというのは普通にやるはずなので、あえてそうしていなかったのってなんか理由あったっけ?みたいな)ので見ていただけると🙏
cc: Collaborators (@mei23 @rinsuki @acid-chicken あたり?)
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テスト失敗したのでなんか問題ありそう
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subscribeは使い回すと死にそう publishは使い回してもたぶん大丈夫 (適当)
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
って思ったけどなんか普通に動きそうな気がするな とりあえず re-run してみた
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ローカルで
ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context
が出た48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ひとつのコネクションで subscribe と publish は同時にできないのか
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
別にした
syuilo/Misskey.old@5c3a56b
syuilo/Misskey.old@00bc097
48ea805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テストは通った