Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL implementation #4635

Open
syuilo opened this issue Apr 5, 2019 · 6 comments
Open

GraphQL implementation #4635

syuilo opened this issue Apr 5, 2019 · 6 comments
Labels
🧩API Interface between server and client ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR

Comments

@syuilo
Copy link
Member

syuilo commented Apr 5, 2019

Summary
@syuilo syuilo added 🧩API Interface between server and client ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR 🤢Difficulty: Tough labels Apr 5, 2019
YuzuRyo61 pushed a commit to YuzuRyo61/misskey that referenced this issue Nov 27, 2020
GraphQL base URL implemented (misskey-dev#4635)
d4c1f51
@YuzuRyo61
Copy link
Contributor

YuzuRyo61 commented Dec 4, 2020 •
edited
Loading

ユーザーの認証をどうするかが大きな課題。
ヘッダーにトークンを収めるのか、URLのクエリに入れるのかでやり方も変わってくるし、
一部のGraphQLクエリやミューテーションは認証が必要とかってのもある（できるのであれば）

@rinsuki
Copy link
Contributor

rinsuki commented Dec 4, 2020

URLのクエリには入れるべきじゃない(あちこちにログ残りがち)のでまあヘッダーでは

@rinsuki
Copy link
Contributor

rinsuki commented Dec 4, 2020

POSTする時にi=hogehoge&query=...っていうのも手ではあるか

@EbiseLutica
Copy link
Contributor

Authorization: Bearer <i> が良さそう

@syuilo
Copy link
Member Author

syuilo commented Aug 21, 2021

Nest.jsで書き直す選択肢もありそう

@acid-chicken
Copy link
Member

サードパーティ向けの互換性が強い API として有力な気がしているのでフロントエンドの繋ぎ込みを置き換えるか否かを抜きにやりたさある

@acid-chicken acid-chicken mentioned this issue Apr 24, 2023
Open
@syuilo syuilo mentioned this issue Jun 18, 2023
Open
@acid-chicken acid-chicken mentioned this issue Jun 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧩API Interface between server and client ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@syuilo @rinsuki @EbiseLutica @YuzuRyo61 @acid-chicken