Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image order gets scrambled when federating #5558

Closed
chocological00 opened this issue Oct 28, 2019 · 3 comments 路 Fixed by #5561
Closed

Image order gets scrambled when federating #5558

chocological00 opened this issue Oct 28, 2019 · 3 comments 路 Fixed by #5561
Assignees
@mei23
Labels
馃悰Bug Unexpected behavior 馃寣Federation The Federation/ActivityPub feature

Comments

@chocological00
Copy link
Contributor

馃挕 Summary

When posting a note with manually ordered images, the activitypub renderer reorder images to uploaded order.

馃檪 Expected Behavior

Images should be federated in the order set in Misskey.

鈽癸笍 Actual Behavior

Images get federated in DB row order.

馃摑 Steps to Reproduce

On local the image is ordered fine, but on remote the image order is scrambled.

image
image

馃搶 Environment

Misskey 11.34.0 -> Other ActivityPub instances (including other Misskey Instance)
@chocological00 chocological00 added the 鈿狅笍bug? This might be a bug label Oct 28, 2019
@chocological00
Copy link
Contributor Author

Temporary fix here, but maybe there is a way to order this in ORM instead of using .sort()?

@mei23
Copy link
Contributor

mei23 commented Oct 28, 2019 •
edited

Related to (or duplicated?) https://github.com/syuilo/misskey/issues/5550

@mei23 mei23 mentioned this issue Oct 28, 2019
Merged
@mei23
Copy link
Contributor

mei23 commented Oct 28, 2019 •
edited

By Misskey's drive feature, sometimes DB order vs attached order is different.
So you need to preserve the attached order, instead of sorting by the id (DB row order / uploaded order).

@mei23 mei23 added 馃寣Federation The Federation/ActivityPub feature 馃悰Bug Unexpected behavior and removed 鈿狅笍bug? This might be a bug labels Oct 28, 2019
@mei23 mei23 self-assigned this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mei23 mei23

Labels
馃悰Bug Unexpected behavior 馃寣Federation The Federation/ActivityPub feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve the attached order in AP mei23/misskey
2 participants
@mei23 @chocological00