New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
通知ミュートの判定がおかしい #6676
Labels
🐛Bug
Unexpected behavior
Comments
includingNotificationTypesってそもそもどうしてnullableにしたんだろう |
デフォルトのNULLは全許可にしないといけないからたぶんこう - const isMuted = !profile?.includingNotificationTypes?.includes(type);
+ const isMuted = !(profile?.includingNotificationTypes == null || profile.includingNotificationTypes.includes(type));
|
あー、これホワイトリストだっけ |
たぶんスキーマに、通知設定全体が未定義 と この種別の通知については未定義 の両方の概念があったほうが良かったのかなと
|
そもそもブラックリスト形式でよかったような気も |
excludeNotificationTypes でよかったのかも |
直接コミットした( |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
💡 Summary
create-notificationサービスのisMutedの判定がおかしいっぽい?
多分だけど、includingNotificationTypesがnullの場合に判定がおかしくなる?
The text was updated successfully, but these errors were encountered: