リモートフォローは必ず承認待ち状態を挟むように変更 #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます🙏🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2604, #2605
リモートフォロー時は、ローカルで鍵と認識している否かを問わず
必ず一旦フォローリクエストにするように変更しています。
（即時フォロー済みに変更するのではなく）
UIやisLockedを見てる部分も変更しています。
変更前
相手がリモートの場合、鍵垢と認識している場合のみフォローリクエスト
変更後
相手がリモートの場合、常にフォローリクエスト
一時的にスタータスは承認待ちになる（DBもUIも）
リモートから Accept/Rejectが返ってきたタイミングで
→DBを承認待ちから変更(フォロー済み/未フォローへ)
→publish follow/unfollow event
→eventを受けてUIのフォローボタンが変わる