Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twemojiで合字に対応 #3140

Merged
merged 2 commits into from Nov 6, 2018
Merged

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Nov 6, 2018

Twemojiで合字に対応してなかったのを対応するようにしています

合字が合字として表示されないのがされるようになる(上が対応前, 下が対応後)
image

ピッカーでjobが全てman扱いになったりしてるのがうまくいくようになる
image

@acid-chicken
Copy link
Member

acid-chicken commented Nov 6, 2018

正規表現を別ファイルに分割した方がいいかもしれません。
FYI: https://github.com/syuilo/misskey/pull/3117#pullrequestreview-171424596

https://github.com/syuilo/misskey/blob/31b7626d018f3e241ddeac5b723c18fa41088bf5/src/mfm/parse/elements/emoji.regex.ts#L1

@mei23
Copy link
Contributor Author

mei23 commented Nov 6, 2018

とりあえず分割しといたわ

@syuilo syuilo merged commit 3b6ab32 into misskey-dev:develop Nov 6, 2018
@syuilo
Copy link
Member

syuilo commented Nov 6, 2018

ありがとうございます🙏

@mei23 mei23 deleted the mei-1106-twemoji-goji branch July 21, 2019 19:30
nokotaro pushed a commit to nokotaro/misskey that referenced this pull request Jan 30, 2022
Bumps [@types/js-yaml](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/js-yaml) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/js-yaml)

---
updated-dependencies:
- dependency-name: "@types/js-yaml"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants