Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-listのgridの高さがsub-note-detailsのdetailsの中だと287pxになってしまっていたのを修正 #5951

Merged
merged 6 commits into from Feb 19, 2020

Conversation

tamaina
Copy link
Member

@tamaina tamaina commented Feb 15, 2020

Summary

Issue番号不明

macOS Safari, Windows Firefox and Windows Chromeで動作確認済み

@tamaina tamaina changed the title media-listのgridno media-listのgridの高さがsub-note-detailsのdetailsの中だと287pxになってしまっていたのを修正 Feb 15, 2020
@tamaina tamaina requested a review from syuilo February 15, 2020 12:24
@tamaina
Copy link
Member Author

tamaina commented Feb 18, 2020

なんかマージもコードレビューもされないのでcloseしますね

@tamaina tamaina closed this Feb 18, 2020
@tamaina tamaina reopened this Feb 18, 2020
@tamaina
Copy link
Member Author

tamaina commented Feb 18, 2020

このバグやっぱ酷いのでやっぱり復活します

@syuilo syuilo merged commit f456feb into misskey-dev:develop Feb 19, 2020
@syuilo
Copy link
Member

syuilo commented Feb 19, 2020

ありがとうございます🙏

@syuilo
Copy link
Member

syuilo commented Feb 20, 2020

タイムラインが画面にないときにノートが追加されると画像が表示されないバグがありそう

@tamaina
Copy link
Member Author

tamaina commented Feb 21, 2020

タイムラインが画面にないとき

というのはdocument.hidden === true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants