Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fail_if_returned_late, behavior is similar to fail_if_returned_early #23

Merged
merged 1 commit into from Apr 22, 2019

Conversation

oaxlin
Copy link
Contributor

@oaxlin oaxlin commented Feb 9, 2015

Please allow for stricter checking of test plans. An option already exists for early returns. However running too many can be just as bad.

This pull request gives Test::Class the same control over too many tests that it already had for too few.

@karenetheridge
Copy link
Contributor

note to self: should be in a -TRIAL release first.

@karenetheridge karenetheridge self-assigned this Jun 6, 2015
@jgoodman
Copy link
Collaborator

jgoodman commented Oct 2, 2015

Hi,

Can we get this patch merged in? I would like to have this feature in my tests.

@karenetheridge: You mentioned "should be in a -TRIAL release first". I am not seeing this as a branch, is this a separate repo? If so, should future pull requests go to that and where would it be located?

Thanks!

@pali
Copy link
Contributor

pali commented Feb 21, 2019

Hi! I would like to use this fail_if_returned_late feature in my Test::Class::WithStrictPlan module.

@karenetheridge could you review this pull request?

@karenetheridge karenetheridge removed their assignment Feb 21, 2019
@choroba
Copy link

choroba commented Mar 8, 2019

What blocks this from merging, please?

@karenetheridge
Copy link
Contributor

I don't use Test::Class anymore (I never did all that much actually; I don't understand its internals), so I am unable to review and test any proposed patches. I am not sure if Adrian is around anymore either.

I can ship proposed patches as trial releases, but am unable to guarantee any level of quality for them.

Test::Class::Moose is a well-maintained variant though; it may have resolved this issue already.

@adrianh
Copy link
Collaborator

adrianh commented Mar 9, 2019

Yup - I'm not active in the perl world anymore. Back in the day I tried repeatedly to get this adopted but nobody stood up. If anybody does want to formally adopt the module please do (and remind me of what hoops I need to jump through to make it happen :-)

@jgoodman
Copy link
Collaborator

Hey, I could adopt this!

@adrianh
Copy link
Collaborator

adrianh commented Mar 12, 2019

Sweet! Thanks Kaycie. I'll give you repo access once I remember how to. Chuck me your PAUSE id and I'll add you in as primary maintainer.

@jgoodman
Copy link
Collaborator

@adrianh my PAUSE id is jgoodman :)

@adrianh
Copy link
Collaborator

adrianh commented Mar 14, 2019

I apparently have the memory of an idiot. And Karen is the current owner of the module. @karenetheridge if you don't wanna maintain any more do you wanna transfer to Kaycie ?

@pali
Copy link
Contributor

pali commented Mar 27, 2019

Any update on this? Btw, @adrianh you are still co-maintainer of Test::Class, see:
https://metacpan.org/permission/distribution/Test-Class

@adrianh
Copy link
Collaborator

adrianh commented Mar 29, 2019

I'm might be co-maintainer — but I shouldn't be. No longer competent enough to release.

@pali
Copy link
Contributor

pali commented Apr 11, 2019

@karenetheridge Can you process that maintenance transfer?

@karenetheridge
Copy link
Contributor

No I cannot. I'm not a PAUSE admin.

@pali
Copy link
Contributor

pali commented Apr 12, 2019

@exodist Hi! According to CPAN you are owner of Test-Class distribution:
https://metacpan.org/permission/distribution/Test-Class

Could you transfer ownership to @jgoodman? See whole issue, neither @adrianh nor @karenetheridge can do it and Test-Class distribution is already unmaintained.

@exodist
Copy link
Contributor

exodist commented Apr 12, 2019

Gladly... and done. Have fun @jgoodman.

@exodist
Copy link
Contributor

exodist commented Apr 12, 2019

Hmm, the transfer did not bump me to a co-maint, it removed me completely. I do not expect to need to do anything, but it might be a good idea to keep me as a co-maint, so if someone wants to add me back on as a co-maint that might be a good idea.

@pali
Copy link
Contributor

pali commented Apr 17, 2019

Great! @jgoodman can you now process pending pull requests?

@jgoodman
Copy link
Collaborator

@exodist I added you back in as a co-maint

@pali So far I am planning on either this Saturday or Sunday to devote time to this module.

@jgoodman jgoodman mentioned this pull request Apr 22, 2019
@jgoodman jgoodman merged commit 926e88d into mjgardner:master Apr 22, 2019
@choroba
Copy link

choroba commented May 14, 2020

The trial release was moved to backpan. Were there any problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants