New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create fail_if_returned_late, behavior is similar to fail_if_returned_early #23
Conversation
note to self: should be in a -TRIAL release first. |
Hi, Can we get this patch merged in? I would like to have this feature in my tests. @karenetheridge: You mentioned "should be in a -TRIAL release first". I am not seeing this as a branch, is this a separate repo? If so, should future pull requests go to that and where would it be located? Thanks! |
Hi! I would like to use this @karenetheridge could you review this pull request? |
What blocks this from merging, please? |
I don't use Test::Class anymore (I never did all that much actually; I don't understand its internals), so I am unable to review and test any proposed patches. I am not sure if Adrian is around anymore either. I can ship proposed patches as trial releases, but am unable to guarantee any level of quality for them. Test::Class::Moose is a well-maintained variant though; it may have resolved this issue already. |
Yup - I'm not active in the perl world anymore. Back in the day I tried repeatedly to get this adopted but nobody stood up. If anybody does want to formally adopt the module please do (and remind me of what hoops I need to jump through to make it happen :-) |
Hey, I could adopt this! |
Sweet! Thanks Kaycie. I'll give you repo access once I remember how to. Chuck me your PAUSE id and I'll add you in as primary maintainer. |
@adrianh my PAUSE id is jgoodman :) |
I apparently have the memory of an idiot. And Karen is the current owner of the module. @karenetheridge if you don't wanna maintain any more do you wanna transfer to Kaycie ? |
Any update on this? Btw, @adrianh you are still co-maintainer of Test::Class, see: |
I'm might be co-maintainer — but I shouldn't be. No longer competent enough to release. |
@karenetheridge Can you process that maintenance transfer? |
No I cannot. I'm not a PAUSE admin. |
@exodist Hi! According to CPAN you are owner of Test-Class distribution: Could you transfer ownership to @jgoodman? See whole issue, neither @adrianh nor @karenetheridge can do it and Test-Class distribution is already unmaintained. |
Gladly... and done. Have fun @jgoodman. |
Hmm, the transfer did not bump me to a co-maint, it removed me completely. I do not expect to need to do anything, but it might be a good idea to keep me as a co-maint, so if someone wants to add me back on as a co-maint that might be a good idea. |
Great! @jgoodman can you now process pending pull requests? |
The trial release was moved to backpan. Were there any problems? |
Please allow for stricter checking of test plans. An option already exists for early returns. However running too many can be just as bad.
This pull request gives Test::Class the same control over too many tests that it already had for too few.