Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only and upload password settings have no effect #221

Open
Virkkunen opened this issue Sep 11, 2023 · 3 comments
Open

Read only and upload password settings have no effect #221

Virkkunen opened this issue Sep 11, 2023 · 3 comments

Comments

@Virkkunen
Copy link

Describe the bug
Read only and upload password settings have no effect. Users can still upload and delete pastas without a password (or with any password)

To Reproduce
Steps to reproduce the behavior:

  1. Set MICROBIN_READONLY=true and a MICROBIN_UPLOADER_PASSWORD
  2. Restart the container with docker compose down and docker compose --env-file .env up --detach
  3. Upload a pasta without typing the uploader password
  4. Pasta is uploaded normally

Expected behavior
Pastas are not allowed to be uploaded without providing the uploader password

@secondubly
Copy link

Can confirm this does not work in the docker environment - I've confirmed that it does work in the existing master branch, so maybe the docker image is out date?

@secondubly
Copy link

Can confirm this does not work in the docker environment - I've confirmed that it does work in the existing master branch, so maybe the docker image is out date?

so it looks like in the current docker setup, the MICROBIN_UPLOADER_PASSWORD isn't being read at all? If you run docker exec <container> env it prints out all the env variables except MICROBIN_UPLOADER_PASSWORD.

@secondubly
Copy link

secondubly commented Oct 9, 2023

I fixed the issue and created a PR 🙂 it was actually a pretty simple fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants