Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples only cover lower-left corner of Pyglet window #19

Closed
akx opened this issue Jun 2, 2022 · 4 comments · Fixed by #20
Closed

Examples only cover lower-left corner of Pyglet window #19

akx opened this issue Jun 2, 2022 · 4 comments · Fixed by #20

Comments

@akx
Copy link
Contributor

akx commented Jun 2, 2022

Broke this out of #18.

The examples only cover the lower-left corner of the Pyglet window:

Screenshot 2022-06-02 at 21 15 04

Screenshot 2022-06-02 at 21 18 38

Other output, such as the mp4 generated by ffmpeg_stream.py are just fine (1280x720).


Python 3.9.12 on macOS 10.15.7 on AMD Radeon Pro 5500M 4 GB graphics (macbook pro 2019), libraries:

ffmpeg-python==0.2.0
glcontext==2.3.6
moderngl==5.6.4
Pillow==9.1.1
pyglet==1.5.26
@szabolcsdombi
Copy link
Owner

hi, thank you for reporting this.

it seems the window size is not aligned with the framebuffer size.
I have to look into how to get the proper framebuffer size.
right now the examples assume a 1280x720 window needs a 1280x720 framebuffer (taking the size from the window directly).
for me it seems the retina display requires the width and height to be doubled.

the actual fix should go into the window.py fixing all the windowed examples.
the window.size property is not set properly.

i look into this

@akx
Copy link
Contributor Author

akx commented Jun 3, 2022

Just got back to the office and was about to report that this isn't an issue on the external LoDPI screen :) I'll try out the PR!

@szabolcsdombi
Copy link
Owner

so #20 does not resolve the issue?

@szabolcsdombi
Copy link
Owner

the examples are not resizable as it would require extra logic that is out of the scope of the basic examples.
however, I plan to add examples for resizable windows too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants