Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same bug , fromData and toData , the draw is not completely the same . #309

Closed
tempbing opened this issue Oct 3, 2017 · 3 comments
Closed
Labels

Comments

@tempbing
Copy link

tempbing commented Oct 3, 2017

@szimek
Tonight , I want to take signature_pad in my another project ( it must support "undo")...
I'm sure that , this following bug has always been there ( signature_pad v2.3.2 ). So I submit this issue .

The same bug , fromData and toData , the draw is not completely the same .
#270

Do you have the impression ?

Thanks very much for reply.
On this fixed version: (https://jsfiddle.net/szimek/h80phxyr/11/)
I see the problem again .
You can draw some curves (like six letters "jjJJjj") ,then click "undo" button six times .
On this online demo.: (https://jsfiddle.net/szimek/h80phxyr/11/)
I have a try ,maybe i don't understand ...
The picture compare.
http://huobei.oss-cn-shenzhen.aliyuncs.com/02.png
http://huobei.oss-cn-shenzhen.aliyuncs.com/01.png
( Can you see my picture ?
Other pic link:
http://foreign-oss.oss-us-west-1.aliyuncs.com/02.png
http://foreign-oss.oss-us-west-1.aliyuncs.com/01.png
)

@szimek szimek added the bug label Oct 3, 2017
@szimek
Copy link
Owner

szimek commented Oct 3, 2017

Thanks for submitting it. I won't have time to look into it in the next 2-3 weeks, so it would be great if anyone could take a look at this issue and come up with a fix ;)

@PieterVanPoyer
Copy link

PieterVanPoyer commented Oct 23, 2017

Hello,

I think your problem can be solved by setting following property:

throttle: false

http://jsfiddle.net/PieterVanPoyer/7q0hzzuy/

The throttle property makes the signature_pad more performant and smooth, but makes the undo action a little more unpredictable.
Defaults:

throttle: 16

I've created the fiddle with the throttle property to false. Please, try your testcase again.
I'd love to submit a fix for this issue later.

@UziTech
Copy link
Collaborator

UziTech commented Nov 15, 2021

closing as stale

@UziTech UziTech closed this as completed Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants