Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: background color is not saved for SVG format #665

Closed
rodrigoaguilera opened this issue Oct 16, 2022 · 1 comment · Fixed by #668
Closed

Bug: background color is not saved for SVG format #665

rodrigoaguilera opened this issue Oct 16, 2022 · 1 comment · Fixed by #668

Comments

@rodrigoaguilera
Copy link

rodrigoaguilera commented Oct 16, 2022

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Changing the background color and then saving as SVG doesn't keep the background color information.

What is the expected behavior?
The SVG is displayed with the same background color as it was displayed on the canvas of signature pad

Which versions of SignaturePad, and which browser / device are affected by this issue? Did this work in previous versions of SignaturePad?
Signature pad 4.0.10 with firefox and chrome. I don't think it ever worked before

I suggest to use a <rect width="100%" height="100%" fill="COLOR"/> as the first element of the SVG document.
I got it from https://stackoverflow.com/questions/11293026/default-background-color-of-svg-root-element

@github-actions
Copy link

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants