Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set if historyContentView.backgroundColor #41

Closed
syky27 opened this issue Jan 29, 2016 · 1 comment
Closed

Cannot set if historyContentView.backgroundColor #41

syky27 opened this issue Jan 29, 2016 · 1 comment

Comments

@syky27
Copy link
Contributor

syky27 commented Jan 29, 2016

Hi!
First of all, I would like to say that this is one of the greatest new functionality I have seen in a long time, It perfectly fits in my app!

There is just one little tiny detail on iOS 9.2 setting up background color gets overriten in SAHistoryNavigationViewController.swift on line 49. I haven't tested this on any other version of iOS, but I am pretty sure that it won't work also.

So I have made a really tiny change, basically just check if backgroundColor is already set, if so It won't get ser on grayColor.

Tested and It works now.

@syky27
Copy link
Contributor Author

syky27 commented Jan 29, 2016

Fixed by #42

@syky27 syky27 closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant