Some desired changes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On unwind segue, the navbar moves behind the status bar. This highlights that bug.
To handle interactive pop gesture, make yourself delegate for navigationBar. Remove last image when item popped in nav bar.
A crash occurs if user goes back by pressing on back button very fast repeatedly. This occurs because popToViewController: and navigationBar(navigationBar:, didPopItem item:) are called simultaenously removing two screen shots. By keeping a reference to the navigation item, we check in navigation bar delegate method if the required screen shot has been removed already.
This reverts commit c4579e4. This is not required since the item given in didPopItem: is of the VC whose screentshot has not been prepared yet.
|
Hi @ayushgoel |
|
馃憤 When do you plan to do a release for this? 馃槂 |
|
i'll release during this week! |
|
released 2.1.0 |
|
馃啋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here:
SAHistoryNavigationViewControllerextends behind status bar if a modalUIViewControlleris presented.UIViewControllermodally.Some of these changes might be in conflict with what you had planned for this pod. In that case, I would like to create a different pod from this.
Also, if you have any suggestions for the code which could make this merge, would love to know them. 馃槆