Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

[Poll] Continuation of feature/4? #356

Closed
hasezoey opened this issue Jul 25, 2019 · 4 comments
Closed

[Poll] Continuation of feature/4? #356

hasezoey opened this issue Jul 25, 2019 · 4 comments
Labels

Comments

@hasezoey
Copy link
Contributor

mainly targeting @Ben305 @vinczedani @szokodiakos, but feedback from anyone is appreciated

I would ask if the continuation of the branch(/ something like that) would be appreciated?

Advantages would be:

  • when using some thing like await new DummyModel({prop: 'hi'} as DummyType).save(); would not in any case require the typegoose(current) function to build a model, but still require the virtual properties ....
  • would not add overhead with each class created

Disadvantages would be:

  • i dont know any currently

would target something like Typegoose@6.0.0 for this kind of feature

@Ben305
Copy link
Collaborator

Ben305 commented Jul 29, 2019

@hasezoey I haven't looked into the feature/4 branch but when there are some useful features inside, I would love to see these changes in master.

Unfortunately, my time is very limited at the moment...

@hasezoey
Copy link
Contributor Author

hasezoey commented Jul 29, 2019

I haven't looked into the feature/4 branch but when there are some useful features inside, I would love to see these changes in master.

currently feature/4 removes the Typegoose class, and makes all functions inside not needing a class, so this would resolve these setModelForClass etc is missing from T

but it would be a breaking change

@hasezoey hasezoey changed the title [Question][Vote] Continuation of feature/4? [Vote] Continuation of feature/4? Jul 31, 2019
@hasezoey hasezoey mentioned this issue Jul 31, 2019
14 tasks
@Ben305
Copy link
Collaborator

Ben305 commented Aug 1, 2019

I think it's worth it, even it's a breaking change.

@hasezoey hasezoey changed the title [Vote] Continuation of feature/4? [Poll] Continuation of feature/4? Aug 4, 2019
@hasezoey
Copy link
Contributor Author

hasezoey commented Aug 5, 2019

Closed - It will be integrated in 6.0.0, but a poll about how in #373

@hasezoey hasezoey closed this as completed Aug 5, 2019
hasezoey referenced this issue in typegoose/typegoose Aug 5, 2019
- outsourcing all functions in the Typegoose Class
-  refactoring all test-models for the new style
- adding migration note for it
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants